Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop.govuk #5442

Merged
merged 16 commits into from
Jul 7, 2023
Merged

Update rubocop.govuk #5442

merged 16 commits into from
Jul 7, 2023

Commits on Jul 4, 2023

  1. build(deps-dev): bump rubocop-govuk from 4.10.0 to 4.11.0

    Bumps [rubocop-govuk](https://github.com/alphagov/rubocop-govuk) from 4.10.0 to 4.11.0.
    - [Changelog](https://github.com/alphagov/rubocop-govuk/blob/main/CHANGELOG.md)
    - [Commits](alphagov/rubocop-govuk@v4.10.0...v4.11.0)
    
    ---
    updated-dependencies:
    - dependency-name: rubocop-govuk
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and colinbruce committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    fc09af9 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Configuration menu
    Copy the full SHA
    7a98475 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ac88dd9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f90ce4c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    00115cb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e717a72 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ae9793b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    00c2d4f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6d7f588 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    eb90176 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    56410a9 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    88da887 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fbc646b View commit details
    Browse the repository at this point in the history
  13. Update FactoryBot/FactoryAssociationWithStrategy cop handling

    Update factories/hmrc/responses in line with guidance
    colinbruce committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    a7c3c38 View commit details
    Browse the repository at this point in the history
  14. Update RSpec/IndexedLet set Max to 2

    Address all infringing test harnesses
    colinbruce committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    6fa7c50 View commit details
    Browse the repository at this point in the history
  15. Add exception rules for new cops

    FactoryBot/FactoryAssociationWithStrategy, exclude spec/factories/legal_aid_applications.rb
    This is because there are too many traits that create objects that loop back
    
    RSpec/IndexedLet, set the max number of spec variables to 2
    
    This will allow up to 2 number let variables e.g.
    ```ruby
        let!(:transaction1) { create(:bank_transaction, :benefits, happened_at: 10.days.ago) }
        let!(:transaction2) { create(:bank_transaction, :benefits, happened_at: 40.days.ago) }
    ```
    But trying to create `transaction3` will raise an error
    
    The aim is to slowly reduce the number over time to 1 as we phase out the use of large numbered blocks
    
    We also exclude spec/services/cfe/* as the CFE classic integration is due to be deleted soon
    colinbruce committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    5adeb2e View commit details
    Browse the repository at this point in the history