-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rubocop.govuk #5442
Merged
Merged
Update rubocop.govuk #5442
Commits on Jul 4, 2023
-
build(deps-dev): bump rubocop-govuk from 4.10.0 to 4.11.0
Bumps [rubocop-govuk](https://github.com/alphagov/rubocop-govuk) from 4.10.0 to 4.11.0. - [Changelog](https://github.com/alphagov/rubocop-govuk/blob/main/CHANGELOG.md) - [Commits](alphagov/rubocop-govuk@v4.10.0...v4.11.0) --- updated-dependencies: - dependency-name: rubocop-govuk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for fc09af9 - Browse repository at this point
Copy the full SHA fc09af9View commit details
Commits on Jul 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7a98475 - Browse repository at this point
Copy the full SHA 7a98475View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac88dd9 - Browse repository at this point
Copy the full SHA ac88dd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f90ce4c - Browse repository at this point
Copy the full SHA f90ce4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00115cb - Browse repository at this point
Copy the full SHA 00115cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e717a72 - Browse repository at this point
Copy the full SHA e717a72View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae9793b - Browse repository at this point
Copy the full SHA ae9793bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00c2d4f - Browse repository at this point
Copy the full SHA 00c2d4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d7f588 - Browse repository at this point
Copy the full SHA 6d7f588View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb90176 - Browse repository at this point
Copy the full SHA eb90176View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56410a9 - Browse repository at this point
Copy the full SHA 56410a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88da887 - Browse repository at this point
Copy the full SHA 88da887View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbc646b - Browse repository at this point
Copy the full SHA fbc646bView commit details -
Update FactoryBot/FactoryAssociationWithStrategy cop handling
Update factories/hmrc/responses in line with guidance
Configuration menu - View commit details
-
Copy full SHA for a7c3c38 - Browse repository at this point
Copy the full SHA a7c3c38View commit details -
Update RSpec/IndexedLet set Max to 2
Address all infringing test harnesses
Configuration menu - View commit details
-
Copy full SHA for 6fa7c50 - Browse repository at this point
Copy the full SHA 6fa7c50View commit details -
Add exception rules for new cops
FactoryBot/FactoryAssociationWithStrategy, exclude spec/factories/legal_aid_applications.rb This is because there are too many traits that create objects that loop back RSpec/IndexedLet, set the max number of spec variables to 2 This will allow up to 2 number let variables e.g. ```ruby let!(:transaction1) { create(:bank_transaction, :benefits, happened_at: 10.days.ago) } let!(:transaction2) { create(:bank_transaction, :benefits, happened_at: 40.days.ago) } ``` But trying to create `transaction3` will raise an error The aim is to slowly reduce the number over time to 1 as we phase out the use of large numbered blocks We also exclude spec/services/cfe/* as the CFE classic integration is due to be deleted soon
Configuration menu - View commit details
-
Copy full SHA for 5adeb2e - Browse repository at this point
Copy the full SHA 5adeb2eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.