Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-4214: Update partner description #5444

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

agoldstone93
Copy link
Contributor

What

Link to story

  • Update partner description
  • Remove unused code

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@agoldstone93 agoldstone93 added the ready for review Please review label Jul 5, 2023
@agoldstone93 agoldstone93 marked this pull request as ready for review July 5, 2023 15:09
@agoldstone93 agoldstone93 requested a review from a team as a code owner July 5, 2023 15:09
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@agoldstone93 agoldstone93 added approved Approved by code reviewers and removed ready for review Please review labels Jul 5, 2023
@agoldstone93 agoldstone93 merged commit 0cce3bf into main Jul 6, 2023
7 checks passed
@agoldstone93 agoldstone93 deleted the AP-4214/Update-partner-description branch July 6, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants