Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-4266: Remove partner address #5456

Merged
merged 12 commits into from
Jul 7, 2023
Merged

Conversation

colinbruce
Copy link
Contributor

@colinbruce colinbruce commented Jul 6, 2023

What

Link to story

This PR removes:

  • the Is the partner's correspondence address the same as your client's? and all subsequent address pages, e.g. postcode, address choice, etc
  • the display of the address from all partials, any testing of such and the local eentires for those pages
  • the database entries for partner addresses

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce force-pushed the ap-4266/remove-partner-address branch 2 times, most recently from 7631d87 to e21c8be Compare July 7, 2023 07:40
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@colinbruce colinbruce marked this pull request as ready for review July 7, 2023 07:53
@colinbruce colinbruce requested a review from a team as a code owner July 7, 2023 07:53
@colinbruce colinbruce added the ready for review Please review label Jul 7, 2023
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 looks good to me.

Pulled and did a cursory search for other things that may have been missed for deletion and could not find anything obvious.

@colinbruce colinbruce added approved Approved by code reviewers UAT and removed ready for review Please review labels Jul 7, 2023
@colinbruce colinbruce force-pushed the ap-4266/remove-partner-address branch from e21c8be to 1b7aa32 Compare July 7, 2023 13:04
@colinbruce colinbruce merged commit 60d36ac into main Jul 7, 2023
5 checks passed
@colinbruce colinbruce deleted the ap-4266/remove-partner-address branch July 7, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers UAT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants