Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add missing close dl tag #5458

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Fix: Add missing close dl tag #5458

merged 1 commit into from
Jul 10, 2023

Conversation

colinbruce
Copy link
Contributor

What

This keeps being flagged by my IDE and is annoying! :)

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce
Fix: Add missing close dl tag
39f74d1 
This keeps being flagged by my IDE and is annoying! :)
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@colinbruce colinbruce marked this pull request as ready for review July 7, 2023 07:32
@colinbruce colinbruce requested a review from a team as a code owner July 7, 2023 07:32
@colinbruce colinbruce added the ready for review Please review label Jul 7, 2023
jsugarman
jsugarman approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 can't tell if that is indented to the right level though. it looks off by one

@jsugarman jsugarman added approved Approved by code reviewers and removed ready for review Please review labels Jul 7, 2023
@colinbruce
Copy link
Contributor Author

👍 can't tell if that is indented to the right level though. it looks off by one

No, it's on the left margin and matches the opening tag 👍

@colinbruce colinbruce merged commit 17a3c69 into main Jul 10, 2023
7 checks passed
@colinbruce colinbruce deleted the fix/missing-close-tag branch July 10, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsugarman jsugarman jsugarman approved these changes

Assignees
No one assigned
Labels
approved Approved by code reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colinbruce @jsugarman