Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-3805: HRMC request for partner #5459

Merged
merged 10 commits into from
Jul 12, 2023
Merged

AP-3805: HRMC request for partner #5459

merged 10 commits into from
Jul 12, 2023

Conversation

colinbruce
Copy link
Contributor

@colinbruce colinbruce commented Jul 7, 2023 •
edited
Loading

What

Link to story

Part 3 of the ticket to allow HMRC requests for partners

This switches HMRC::CreateResponsesService and HMRC::MockInterfaceResponseService to parse the owner of the HMRC::Response object, whether it is an Applicant or Partner.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce force-pushed the ap-3805-hmrc-request-for-partner-three branch 2 times, most recently from 50ae6c4 to 7e156ed Compare July 10, 2023 08:34
RoseSAK and others added 8 commits July 10, 2023 09:53
@colinbruce
AP-3805 HMRC request for partner
d730436 
Update rspecs to add owner when employment instances are created

Co-authored-by: colinbruce <[email protected]>
@colinbruce
AP-3085 partner HMRC request
b1543b3 
initial attempt to make the HMRC request for the partner

Co-authored-by: colinbruce <[email protected]>
@colinbruce
AP-3805: Test creation of hmrc_response objects
d75278f 
Ensure each party gets 2 responses generated and has ownership set
@colinbruce
AP-3805: Update tests for HMRC::Interface::SubmissionService
f449f28 
Ensure partner will be honoured as a source of data
@colinbruce
AP-3805: Update MockHMRCInterfaceService
dd4ace4 
Ensure partner can be set as owner and the mock uses it
@colinbruce
AP-3805: Update partner feature
33f8540 
Ensure partner model is created
@colinbruce
AP-3805: refactor submission service
ad6e645 
rename the applicant_value -> owner_values
so that it better reflects the actual use
of data internally
@colinbruce
AP-3805: refactor HMRC::CreateResponsesService
ee83232 
* rather than create an empty array and add a value,
  instantiate with the single object and then add the
  partner if needed

* Extract the check_partner? logic to a separate
  method and call in-line to reduce cognitive load
@colinbruce colinbruce force-pushed the ap-3805-hmrc-request-for-partner-three branch from 7e156ed to ee83232 Compare July 10, 2023 12:03
@colinbruce colinbruce added the ready for review Please review label Jul 10, 2023
@colinbruce colinbruce marked this pull request as ready for review July 10, 2023 13:10
@colinbruce colinbruce requested a review from a team as a code owner July 10, 2023 13:10
@colinbruce
AP-3805: Update admin page for HMRC display
42b4d67 
We cannot show the name of the applicant as it
was not a valid GDPR use...

This at least shows that requests have been made
for the applicant and partner, when applicable
agoldstone93
agoldstone93 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@agoldstone93 agoldstone93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question - otherwise looks good

spec/services/hmrc/interface/submission_service_spec.rb Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@colinbruce colinbruce added UAT and removed ready for review Please review labels Jul 12, 2023
@colinbruce colinbruce merged commit d65b0a1 into main Jul 12, 2023
7 checks passed
@colinbruce colinbruce deleted the ap-3805-hmrc-request-for-partner-three branch July 12, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agoldstone93 agoldstone93 agoldstone93 approved these changes

Assignees
No one assigned
Labels
UAT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colinbruce @agoldstone93