Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5297: Fix proceeding search requests for SCA #7159

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

colinbruce
Copy link
Contributor

What

Link to story

When submitting the current proceedings to LFA it expects an array of proceeding codes, e.g. ["PB003", "PB019"]

The previous (join) code in Apply was merging them and sending ["PB003, PB019"]

This caused the proceeding search code to fail and would not match the individual codes, i.e. it could not find a proceeding with the code "PB003, PB019" and would return non-SCA data

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

When submitting the current proceedings to LFA it expects an
array of proceeding codes, e.g. `["PB003", "PB019"]`

The previous (join) code in Apply was merging them and sending
`["PB003, PB019"]`

This caused the proceeding search code to fail and would not
match the individual codes, i.e. it could not find a proceeding
with the code "PB003, PB019" and would return non-SCA data
Copy link

sentry-io bot commented Sep 9, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/services/legal_framework/proceeding_types/all.rb

Function Unhandled Issue
call JSON::ParserError: unexpected token at ' Pr...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link

sonarcloud bot commented Sep 9, 2024

@colinbruce colinbruce marked this pull request as ready for review September 9, 2024 11:15
@colinbruce colinbruce requested a review from a team as a code owner September 9, 2024 11:15
@colinbruce colinbruce added the ready for review Please review label Sep 9, 2024
Copy link
Contributor

@kmahern kmahern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinbruce colinbruce merged commit babfb49 into main Sep 11, 2024
14 checks passed
@colinbruce colinbruce deleted the ap-5297/fix-sca-proceeding-search branch September 11, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants