Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5169 Add separate representation required to merits report #7205

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

RoseSAK
Copy link
Contributor

@RoseSAK RoseSAK commented Sep 19, 2024

What

Link to story

Add separate representation required question to merits report.
Made sure this section doesn't appear on the CYA page or RTA page (which all use the same partials) by checking the application summary_state.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@RoseSAK RoseSAK requested a review from a team as a code owner September 19, 2024 16:17
@RoseSAK RoseSAK marked this pull request as draft September 19, 2024 16:17
@RoseSAK RoseSAK added the WIP Work In Progress label Sep 19, 2024
@RoseSAK RoseSAK marked this pull request as ready for review September 23, 2024 13:22
@RoseSAK RoseSAK force-pushed the ap-5169-add-separate-representation-to-merits-report branch from 6a70acf to e372d1e Compare September 23, 2024 13:54
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but feel free to ignore it 😄
LGTM 👍

app/views/shared/check_answers/_merits.html.erb Outdated Show resolved Hide resolved
Copy link
Contributor

@agoldstone93 agoldstone93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment for consistency

@RoseSAK RoseSAK force-pushed the ap-5169-add-separate-representation-to-merits-report branch from e372d1e to dfbfcf0 Compare September 24, 2024 09:44
Copy link

sonarcloud bot commented Sep 24, 2024

@RoseSAK RoseSAK added ready for review Please review UAT approved Approved by code reviewers and removed WIP Work In Progress ready for review Please review labels Sep 24, 2024
@RoseSAK RoseSAK merged commit d029c25 into main Sep 24, 2024
14 checks passed
@RoseSAK RoseSAK deleted the ap-5169-add-separate-representation-to-merits-report branch September 24, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers UAT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants