Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5313: create MTR A feature flag #7214

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

agoldstone93
Copy link
Contributor

What

Link to story

Create MTR A feature flag

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@agoldstone93 agoldstone93 force-pushed the ap-5313-create-mtr-a-feature-flag branch from 23250e4 to 51a43ad Compare September 23, 2024 11:46
Copy link

sonarcloud bot commented Sep 23, 2024

@agoldstone93 agoldstone93 marked this pull request as ready for review September 23, 2024 12:08
@agoldstone93 agoldstone93 requested a review from a team as a code owner September 23, 2024 12:08
@agoldstone93 agoldstone93 added the ready for review Please review label Sep 23, 2024
@agoldstone93 agoldstone93 force-pushed the ap-5313-create-mtr-a-feature-flag branch from 51a43ad to 8114b67 Compare September 24, 2024 10:14
@agoldstone93 agoldstone93 merged commit d626868 into main Sep 24, 2024
13 checks passed
@agoldstone93 agoldstone93 deleted the ap-5313-create-mtr-a-feature-flag branch September 24, 2024 10:28
@skdejong skdejong added approved Approved by code reviewers and removed ready for review Please review labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants