AP-5315: Fix SCA proceeding search bug

[colinbruce]

What

Link to story

When LFA returns a code that is not present on the page, i.e. an SCA related proceeding on an initial search, previously it showed the failure message and returned from the loop.

This updates the proceedings javascript so that it counts successfully displayed proceedings, using a new, shown, variable. After the loop is complete it then sets the ariaText and shows/hides the no-proceeding-items element accordingly.

Checklist

Before you ask people to review this PR:

• Tests and rubocop should be passing: bundle exec rake
• Github should not be reporting conflicts; you should have recently run git rebase main.
• The standards in the Git Workflow document on Confluence should be followed
• There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
• The PR description should say what you changed and why, with a link to the JIRA story.
• You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
• You should have checked that the commit messages say why the change was made.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud