Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil meta_data for truelayer bank transactions #7221

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

jsugarman
Copy link
Contributor

@jsugarman jsugarman commented Sep 25, 2024

What

Handle nil meta_data for truelayer bank transactions

Caused by the bank_account_has_tax_credits? call of submission processor which fails
via the bank_account.has_tax_credits? method

Sidekiq/CCMS::SubmissionProcessWorker

undefined method `[]' for nil (NoMethodError)

      map { |element| element[key] }
                             ^^^^^

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@jsugarman jsugarman requested a review from a team as a code owner September 25, 2024 07:39
@jsugarman jsugarman changed the title Handle nils in for nil truelayer transaction meta_data Handle nil meta_data for truelayer bank transactions Sep 25, 2024
Copy link

sonarcloud bot commented Sep 25, 2024

@jsugarman jsugarman merged commit 6234421 into main Sep 25, 2024
14 checks passed
@jsugarman jsugarman deleted the jsugarman/handle-nil-truelayer-meta_data branch September 25, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants