AP-5335: Remove ability to add disregarded benefits #7292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsugarman
force-pushed
the
ap-5335/remove-disregarded-benefits
branch
from
14d69fa
to
c2b92c1
Compare
jsugarman
changed the base branch from
main
to
ap-5336/remove-automatic-categorisation-of-benefits
jsugarman
force-pushed
the
ap-5335/remove-disregarded-benefits
branch
from
60b813f
to
4e0edd1
Compare
jsugarman
force-pushed
the
ap-5335/remove-disregarded-benefits
branch
from
c23eddf
to
898984e
Compare
jsugarman
force-pushed
the
ap-5336/remove-automatic-categorisation-of-benefits
branch
from
fddd38e
to
d5ca6e1
Compare
jsugarman
force-pushed
the
ap-5335/remove-disregarded-benefits
branch
2 times, most recently
from
04ba42e
to
9fc1a6e
Compare
Base automatically changed from
ap-5336/remove-automatic-categorisation-of-benefits
to
main
October 16, 2024 08:15
Setting the archived_at value will mean that excluded_benefits exist but are achived/inactive. This means 1. excluded_benefits transaction_type will exist but be inactive 2. that tests will run with production like data in this respect 2. fresh UAT branches will have production like data in this respect NOTE: Removing the transaction type from the NAMES constant was not done because it will cause tests and fresh UAT branches to NOT have the excluded_benefits transaction type at all - i.e. non-production like data Having excluded_benefits be inactive will make the option/field will cause - the option to selected disregarded benefits disappear from the transaction select page (/income_summary) - mid flow - the disregarded benefits output to disappear from CYA means page (/check_income_answers) - mid flow - the disregarded benefits output to disappear from review and print page (/review_and_print_application) - mid-flow - the disregarded benefits output to disappear from submitted_applications review and print page (/submitted_application) - post submission QUESTIONS: Do we want to show disregarded benefit option to mid-flow applications which already have them added? Do we want to show disregarded benefit output to mid-flow applications which already have them added? Alternatively to above, do we want to delete disregarded benefits from mid-flow applications which already have them added? Do we want to show disregarded benefits output on submitted/historical applications which had added them?
Once the Disregarded Benefits section is removed, the provider will no longer have any opportunity to declare receipt of Housing Benefit. Therefore we will need to add the Housing Benefit question that we currently use on the bank upload journey (asked when there are housing costs declared) to the true layer journey for the client as well.
Distinctinction between truelayer and bank statement upload journey no longer applicable so may as well shortcut it.
jsugarman
force-pushed
the
ap-5335/remove-disregarded-benefits
branch
from
9fc1a6e
to
d09a50d
Compare
jsugarman
dismissed
agoldstone93’s stale review
Housing benefit question has had to be added to flow
jsugarman
force-pushed
the
ap-5335/remove-disregarded-benefits
branch
from
d09a50d
to
3e933b9
Compare
…e Housing benefits question The check_income_answers, review_and_print_application, submitted_application and means report need to reflect the addition of the new houseing benefit question that is now part of truelayer.
jsugarman
force-pushed
the
ap-5335/remove-disregarded-benefits
branch
from
3e933b9
to
62781d7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove ability to add disregarded benefits
Link to story
The BA has identified that the caseworkers do not find the addition of transactions pertaining to disregarded benefits, via the clients truelayer journey, helpful when assessing means. The option to add transactions that are “disregarded benefits” should therefore be removed.
agreed with BA that we can ignore the impact on the few applications that will be impacted
this came out of discussion with BA. Existing system has a bug in this regard as HB needs to be discounted from housing payments to reach an actual housing payment amount. Further, since we are removing disregards we need to ask the provider for HB amounts and send the respetive value to CFE just as for the bank statement upload flow.
Note on approach and impact
The disregarded benefits type,
excluded_benefitswas explicitly archived by setting itsarchived_atvalue. This meansexcluded_benefitstransaction type continuesto exist but is not used.
NOTE: Removing the transaction type from the NAMES constant was not done
because it will cause tests and fresh UAT branches to NOT have the
excluded_benefits transaction type at all - i.e. non-production like data
Having excluded_benefits be inactive will make
transaction select page (/income_summary) - mid flow
Checklist
Before you ask people to review this PR:
bundle exec rakegit rebase main.