Skip to content

Commit

Permalink
Add more detail
Browse files Browse the repository at this point in the history
  • Loading branch information
HettieS committed Sep 11, 2024
1 parent 5a3dbf0 commit a8db75c
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,14 @@ Note we use a custom image inside browser tools dockerfile - when you create the

You can see our custom Docker image here - this will update once you've pushed a new image: https://hub.docker.com/r/checkclientqualifiesdocker/circleci-image/tags

Steps to follow are:

1. create an appropriately named branch referencing the puppeteer version upgrade i.e. `puppeteer-22**`
2. update Dockerfile_browser_tools.dockerfile & package.json with the new puppeteer version
3. run `yarn install` to update yarn.lock
4. add your branch name to .github/workflows/browser_tools_docker_image.yml so the new image gets pushed to Dockerhub
5. update .circleci/config.yml to reference the new image

## Branch naming

We name our branches to start with the Jira ticket ID, followed by a short description of the work.
Expand Down

0 comments on commit a8db75c

Please sign in to comment.