Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EL-1640 Removing delete pvc command. Not required #1515

Merged
merged 2 commits into from
Aug 28, 2024
Merged

EL-1640 Removing delete pvc command. Not required #1515

merged 2 commits into from
Aug 28, 2024

Conversation

psweeting1
Copy link
Contributor

-El-1640

What changed and why

Removing delete command for PVC. No longer needed as we now use Helm Deploy. Will remove errors after every PR merge going forward.

Guidance to review

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@psweeting1 psweeting1 requested a review from a team as a code owner August 28, 2024 13:50
@MazOneTwoOne MazOneTwoOne added Approved UAT Keep PR open to keep ephemeral UAT URL alive labels Aug 28, 2024
@psweeting1 psweeting1 merged commit 42fc0ab into main Aug 28, 2024
11 checks passed
@psweeting1 psweeting1 deleted the EL-1640-PVC-remove-delete-command branch August 28, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MazOneTwoOne MazOneTwoOne MazOneTwoOne approved these changes

Assignees
No one assigned
Labels
Approved UAT Keep PR open to keep ephemeral UAT URL alive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psweeting1 @MazOneTwoOne