Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL-1633: Remove text from Partner Other property details page #1517

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

MazOneTwoOne
Copy link
Contributor

Jira ticket

What changed and why

  • display hint text based on #{i18n_key}
  • partner #{i18n_key} hint text key value is blank

Guidance to review

  • n/a

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@MazOneTwoOne MazOneTwoOne marked this pull request as ready for review August 28, 2024 15:30
@MazOneTwoOne MazOneTwoOne requested a review from a team as a code owner August 28, 2024 15:30
Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MazOneTwoOne MazOneTwoOne added Approved UAT Keep PR open to keep ephemeral UAT URL alive and removed Ready For Review labels Aug 29, 2024
@MazOneTwoOne MazOneTwoOne merged commit 3211633 into main Aug 30, 2024
12 checks passed
@MazOneTwoOne MazOneTwoOne deleted the EL-1633-remove-partner-other-property-hint branch August 30, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved UAT Keep PR open to keep ephemeral UAT URL alive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants