Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EL-1689: Puppeteer 23.4.0 upgrade to Chrome 129.0.6668.58 #1549

Merged
merged 1 commit into from
Sep 20, 2024
Merged

EL-1689: Puppeteer 23.4.0 upgrade to Chrome 129.0.6668.58 #1549

merged 1 commit into from
Sep 20, 2024

Conversation

MazOneTwoOne
Copy link
Contributor

@MazOneTwoOne MazOneTwoOne commented Sep 19, 2024 •
edited
Loading

Jira ticket

What changed and why

  • manual upgrade of puppeteer to 23.4.0

Guidance to review

  • n/a

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@MazOneTwoOne MazOneTwoOne marked this pull request as ready for review September 19, 2024 15:05
@MazOneTwoOne MazOneTwoOne requested a review from a team as a code owner September 19, 2024 15:05
@MazOneTwoOne MazOneTwoOne changed the title Puppeteer 23.4.0 upgrade to Chrome 129.0.6668.58 EL-1689: Puppeteer 23.4.0 upgrade to Chrome 129.0.6668.58 Sep 19, 2024
@MazOneTwoOne MazOneTwoOne added the UAT Keep PR open to keep ephemeral UAT URL alive label Sep 19, 2024
@MazOneTwoOne MazOneTwoOne merged commit 6547edf into main Sep 20, 2024
15 checks passed
@MazOneTwoOne MazOneTwoOne deleted the puppeteer-2340 branch September 20, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willc-work willc-work willc-work approved these changes

Assignees
No one assigned
Labels
Approved UAT Keep PR open to keep ephemeral UAT URL alive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MazOneTwoOne @willc-work