Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: CivMeans7 Welsh (Rent) #1599

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

BUGFIX: CivMeans7 Welsh (Rent) #1599

wants to merge 2 commits into from

Conversation

willc-work
Copy link
Contributor

@willc-work willc-work commented Oct 14, 2024 •
edited
Loading

Jira ticket

What changed and why

Updated the field ID
This ID has changed from the previous welsh CM7 form, it looks like it is the only one that changed between versions though.

Guidance to review

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing
  • Branch is generally up to date with main Github - definitely no conflicts
  • No unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • PR description says what changed and why, with a link to the JIRA story.
  • Diff has been checked for unexpected changes being included.
  • Commit messages say why the change was made.

@willc-work willc-work requested a review from a team as a code owner October 14, 2024 10:08
@MazOneTwoOne MazOneTwoOne added the UAT Keep PR open to keep ephemeral UAT URL alive label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MazOneTwoOne MazOneTwoOne MazOneTwoOne approved these changes

Assignees
No one assigned
Labels
Approved UAT Keep PR open to keep ephemeral UAT URL alive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willc-work @MazOneTwoOne