EL-999: e2e-ify all remaining end_to_end specs #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willc-work
reviewed
Jul 6, 2023
| "Investments and valuables\n£700.00Total capital\n£701.00", | ||
| "Total assessed disposable capital£701.00"].each do |line| | ||
| expect(page).to have_content line | ||
| end |
There was a problem hiding this comment.
Is there any value in adding e.g
expect(page).not_to have_content("partner...")
on any of these tests?
willc-work
approved these changes
Jul 6, 2023
patrick-laa
force-pushed
the
el-999-e2e-specs
branch
from
ae88425
to
273ee66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
What changed and why
Of our 'end_to_end' specs, that fill in forms and assert expectations about the CFE payload, only some had been converted to "dual-use" specs that also send the payload to a CFE instance and assert expectations about the results page. This PR updates the rest of them to dual use.
Guidance to review
Checklist
Before you ask people to review this PR: