Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACD-171: Fixed MAAT reference mapping and improved error handling #1236

Merged
merged 1 commit into from
Jun 27, 2024
Merged

ACD-171: Fixed MAAT reference mapping and improved error handling #1236

merged 1 commit into from
Jun 27, 2024

Conversation

mtac50
Copy link
Contributor

@mtac50 mtac50 commented Jun 27, 2024

What

Link to story

  • Fixed MAAT reference mapping.
  • Improved error handling.

Checklist

Before you ask people to review this PR:

  • Tests and linters should be passing
  • Github should not be reporting conflicts; you should have recently run git rebase master.
  • Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
  • You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@mtac50
Squashed commit of the following:
48b3d33 
commit 6e87b69469559f65ff106a1aeab22341c8560994
Author: Michael Clancy <[email protected]>
Date:   Thu Jun 27 12:03:24 2024 +0100

    ACD-171: Fixed rubocop violations

commit 7cb44b2
Author: Michael Clancy <[email protected]>
Date:   Thu Jun 27 09:53:13 2024 +0100

    ACD-171: Fixed MAAT reference mapping and improved error handling for cases that don't exist.
@mtac50 mtac50 requested a review from a team as a code owner June 27, 2024 11:07
@mtac50 mtac50 merged commit 57592bf into main Jun 27, 2024
5 of 7 checks passed
@mtac50 mtac50 deleted the ACD-171-iteration-3-improve-error-handling branch June 27, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exonian exonian exonian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtac50 @exonian