Fix: complete page expects decisions (#719)

app/aggregates/deciding/decision.rb

@@ -55,6 +55,10 @@ def interests_of_justice
       Types::InterestsOfJusticeDecision[@interests_of_justice]
     end
 
+    def complete?
+      @funding_decision.present?
+    end
+
     def attributes
       {
         interests_of_justice:,

app/aggregates/reviewing.rb

@@ -14,6 +14,7 @@ class CannotMarkAsReadyWhenCompleted < Error; end
   class CannotMarkAsReadyWhenSentBack < Error; end
   class CannotSendBackWhenCompleted < Error; end
   class NotReceived < Error; end
+  class IncompleteDecisions < Error; end
 
   class DecisionAdded < Event; end
 

app/aggregates/reviewing/commands/complete.rb

@@ -9,9 +9,12 @@ def call # rubocop:disable Metrics/MethodLength
           review.complete(user_id:)
 
           decisions = review.decision_ids.map do |decision_id|
-            Deciding::LoadDecision.call(
+            decision = Deciding::LoadDecision.call(
               application_id:, decision_id:
             )
+            raise IncompleteDecisions unless decision.complete?
+
+            decision.attributes
           end
 
           DatastoreApi::Requests::UpdateApplication.new(

app/controllers/casework/completes_controller.rb

@@ -4,13 +4,13 @@ class CompletesController < Casework::BaseController
 
     def show; end
 
-    def create # rubocop:disable Metrics/MethodLength
+    def create # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
       Reviewing::Complete.new(
         application_id: @crime_application.id,
         user_id: current_user_id
       ).call
 
-      if FeatureFlags.adding_decisions.enabled?
+      if FeatureFlags.adding_decisions.enabled? && @crime_application.draft_decisions.any?
         redirect_to crime_application_complete_path(@crime_application)
       else
         set_flash :completed

config/locales/en/casework.yml

@@ -45,6 +45,7 @@ en:
       not_allocated_to_appropriate_work_stream:
         - You must be allocated to the %{work_queue} work queue to review this application
         - Contact your supervisor to arrange this
+      incomplete_decisions: Please complete any pending funding decisions
 
 
   primary_navigation:

config/settings.yml

@@ -25,7 +25,7 @@ feature_flags:
     production: true
   adding_decisions:
     local: false
-    staging: true
+    staging: false
     production: false
   other_charges:
     local: true

spec/aggregates/deciding/decision_spec.rb

@@ -23,4 +23,26 @@
       expect(decision.attributes[:comment]).to eq(comment)
     end
   end
+
+  describe '#complete?' do
+    context 'when funding_decision is present' do
+      let(:funding_decision) { 'granted' }
+
+      before do
+        decision.set_funding_decision(user_id: SecureRandom.uuid, funding_decision: funding_decision)
+      end
+
+      it 'returns true' do
+        expect(decision.complete?).to be(true)
+      end
+    end
+
+    context 'when funding_decision is not present' do
+      let(:funding_decision) { nil }
+
+      it 'returns false' do
+        expect(decision.complete?).to be(false)
+      end
+    end
+  end
 end

spec/aggregates/reviewing/complete_spec.rb

@@ -37,4 +37,23 @@
     expect { command.call }.to change { review.state }
       .from(:open).to(:completed)
   end
+
+  context 'when there are incomplete decisions' do
+    before do
+      args = {
+        application_id: application_id,
+        user_id: SecureRandom.uuid,
+        decision_id: SecureRandom.uuid
+      }
+
+      Reviewing::AddDecision.call(**args)
+      Deciding::CreateDraft.call(**args)
+    end
+
+    it 'throws an error' do
+      expect do
+        command.call
+      end.to raise_error(Reviewing::IncompleteDecisions)
+    end
+  end
 end