CRIMRE-374 address error handling, pages and reporting

[timpeat]

Description of change

1. Standardise error responses to reduce information leakages:

• When not authenticated, all requests to service and admin URL redirect to sign in regardless of the existing of the resource.
• When authenticated admin, all requests to the service redirect to the user admin
• When authenticated service user, all requests to user admin render 404

2. Simplify all but application_not_found error page to reduce risk of error loops.

3. Ensure error pages do not render flash messages by default.

4. User errors controller to render all application and middleware errors.

Link to relevant ticket

CRIMRE-374

Notes for reviewer

Screenshots of changes (if applicable)

Before changes:

After changes:

How to manually test the feature

See ticket for criteria.

To render the error pages in development for testing add the following line to config/environments/development.rb

config.action_dispatch.show_exceptions = true
config.consider_all_requests_local = false

[arthurashman]

For logged in users, I don't believe this is working as expected. The ACs are wanting this error page to have the link to all open applications (current behaviour in staging)

[timpeat]

For logged in users, are we able to give them any nav options? I worry that they'll get stuck if the only way back to the app is via the service name or editing the URL

When logged in as a caseworker, if users come across a missing crime application, we do display the primary navigation. However, I prefer not to include the primary navigation on other error pages due to its dependency on database requests.

[arthurashman]

Sorry, Ive annoyingly updated my previous comment. I realised that the ACs said we wanted the link to all open applications which would solve my issue with navigation - but the page rendered isn't that one, so something isn't quite right

[arthurashman]

It's routing to page not found, not application not found

[timpeat]

This is the page that should be shown when logged in and the missing page is a crime application.

[willmcb]

Thanks looks really good - have have added a few non-blocking comments for you to consider :)

[willmcb]

Might need to change this if it is a nino as I just merged that nino change sorry 😬