CRIMRE-389 Surface appeal lodged date, change details and maat id in appeal cases #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurashman
commented
Jul 5, 2023
| it 'includes the page title' do | ||
| expect(page).to have_content I18n.t('crime_applications.show.page_title') | ||
| end | ||
|
|
There was a problem hiding this comment.
Just reordered spec to match order of fields on page
arthurashman
commented
Jul 5, 2023
| it 'includes button to assign' do | ||
| expect(page).to have_content('Assign to your list') | ||
| end | ||
|
|
There was a problem hiding this comment.
Just reordered spec to match order of fields on page
arthurashman
commented
Jul 5, 2023
| it 'does shows the class not determined badge' do | ||
| table_body = find(:xpath, | ||
| "//table[@class='govuk-table app-dashboard-table govuk-!-margin-bottom-9'] | ||
| //tr[contains(td[1], 'Non-listed offence, manually entered')]") |
There was a problem hiding this comment.
Just reordered spec to match order of fields on page
arthurashman
commented
Jul 5, 2023
| it 'does not show the CTAs' do | ||
| expect(page).not_to have_content('Mark as completed') | ||
| end | ||
|
|
There was a problem hiding this comment.
Just reordered spec to match order of fields on page
arthurashman
commented
Jul 5, 2023
|
|
||
| it 'displays calculated overall offence class badgee' do | ||
| expect(page).to have_content('Overall offence class Class C') | ||
| end |
There was a problem hiding this comment.
Just reordered spec to match order of fields on page
arthurashman
commented
Jul 5, 2023
| expect(row).to have_content('Class C') | ||
| it 'displays undetermined overall offence class badge' do | ||
| expect(page).to have_content('Overall offence class Undetermined') | ||
| end |
There was a problem hiding this comment.
Just reordered spec to match order of fields on page
arthurashman
commented
Jul 5, 2023
| "//table[@class='govuk-table app-dashboard-table govuk-!-margin-bottom-9'] | ||
| //tr[contains(td[1], 'Robbery')]") | ||
| expect(table_body).to have_content('Class not determined') | ||
| end |
There was a problem hiding this comment.
Just reordered spec to match order of fields on page
arthurashman
force-pushed
the
CRIMRE-389-show-appeal-details
branch
from
73f1bb2
to
73f5660
Compare
arthurashman
changed the title
willmcb
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In appeal cases surface appeal attributes:
Link to relevant ticket
https://dsdmoj.atlassian.net/browse/CRIMRE-389
Notes for reviewer
Screenshots of changes (if applicable)
Before changes:
After changes:
How to manually test the feature
Put an appeal / appeal with changes case type through Apply, view Case Details section on Review