Remove spaces from nino #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcb
requested review from
timpeat,
arthurashman,
mseedat-moj,
hiboabd and
MohammedHassanLatif
arthurashman
reviewed
Jul 6, 2023
| formatted_nino = applicant.nino.gsub(/\s+/, '').upcase | ||
| [2, 5, 8, 11].each { |i| formatted_nino.insert i, ' ' } if formatted_nino.length == 9 | ||
| formatted_nino | ||
| applicant.nino |
There was a problem hiding this comment.
Are we happy that Apply/the datastore removes any user-input spacing?
There was a problem hiding this comment.
Yep I checked the validation in Apply and it does
arthurashman
approved these changes
Jul 6, 2023
willmcb
force-pushed
the
CRIMRE-388-remove-nino-spaces
branch
from
7e39c12
to
bbff805
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Removes the NINO spaces from review so that the are easier to copy for CWs etc.
Link to relevant ticket
CRIMRE-388
Notes for reviewer
I have left the formatting methof in as it:
Happy to discuss removing this if you think its not needed 👍
Screenshots of changes (if applicable)
Before changes:
After changes:
How to manually test the feature
Look at an applications Client details section, make sure the NINO has no spaces in it.