CRIMAPP-1357 caseworker can add MAAT decisions #726
Conversation
| @@ -15,6 +15,7 @@ MAAT_API_OAUTH_URL='https://oauth.example.com' | |||
| MAAT_API_CLIENT_ID='TestMaatApiClientID' | |||
| MAAT_API_CLIENT_SECRET='TestMaatApiClientSecret' | |||
| MAAT_API_API_URL='https://example.com' | |||
| MAAT_API_STARTING_MAAT_ID=3 | |||
There was a problem hiding this comment.
This constant is set on a per environment basis and is used to prevent unsupported applications being retrieved.
| @@ -1,6 +1,6 @@ | |||
| module Deciding | |||
| class Command < Dry::Struct | |||
| attribute :decision_id, Types::Uuid | |||
| attribute :decision_id, Types::Uuid | Types::Integer | |||
There was a problem hiding this comment.
We use the MAAT ID for the decision_id of MAAT decisions. This is used to create a unique event stream for the decision and ensure idempotency. (NB: we may start receiving notifications from MAAT relating to decisions.)
| attr_reader :application_id, :decision_id, :funding_decision, :comment, | ||
| :state, :reference, :maat_id, :checksum, :case_id | ||
|
|
||
| # For decisions entered on CrimeReview by the caseworker |
| class InterestsOfJusticeSet < RailsEventStore::Event; end | ||
| class FundingDecisionSet < RailsEventStore::Event; end | ||
| class CommentSet < RailsEventStore::Event; end | ||
| class DraftCreatedFromMaat < RailsEventStore::Event; end |
There was a problem hiding this comment.
All of these should use Event, just don't call with build the creating events.
|
|
||
| def call | ||
| with_decision do |decision| | ||
| decision.create_draft(user_id:, application_id:) | ||
| decision.create_draft(user_id:, application_id:, reference:) |
There was a problem hiding this comment.
Including reference in all deciding events simplifies linking to streams based on reference for submission history.
| def interests_of_justice | ||
| return {} if @interests_of_justice.nil? | ||
| return if @interests_of_justice.nil? |
| @@ -5,6 +5,7 @@ class Review | |||
| def initialize(id) | |||
| @id = id | |||
| @decision_ids = [] | |||
| @maat_ids = [] | |||
| apply DecisionAdded.build(self, user_id:, decision_id:) | ||
| end | ||
|
|
||
| def add_maat_decision(decision_id:) |
| @@ -0,0 +1,12 @@ | |||
| <%= govuk_summary_list(card: { title:, actions: }, rows: rows) do |list| | |||
| @@ -3,71 +3,60 @@ class DecisionComponent < ViewComponent::Base | |||
| include AppTextHelper | |||
| include ComponentsHelper | |||
|
|
|||
| def initialize(decision:, decision_iteration: nil, editable: false) | |||
| def initialize(decision:, decision_iteration: nil, show_actions: false) | |||
There was a problem hiding this comment.
confirm show_actions consistent
| @@ -10,7 +10,8 @@ def create | |||
| args = { | |||
| application_id: @crime_application.id, | |||
| user_id: current_user_id, | |||
| decision_id: decision_id | |||
| decision_id: decision_id, | |||
| reference: @crime_application.reference | |||
There was a problem hiding this comment.
We're recording reference in events to aid linking to submission history without having to load the aggregate.
|
|
||
| def new | ||
| @form_object = ::Decisions::MaatIdForm.new( | ||
| application_id: @crime_application.id |
There was a problem hiding this comment.
Does this need reference?
|
|
||
| InterestsOfJusticeDecision = Hash.schema( | ||
| result: InterestsOfJusticeResult, | ||
| details?: String, | ||
| details?: String.optional, |
| raise ActiveRecord::ReadonlyAttributeError, attr_name | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
☝️ prevent setting of anything other than editable prams being updated.
Description of change
Caseworker can add a MAAT decision to an application
Link to relevant ticket
Notes for reviewer
Screenshots of changes (if applicable)
Before changes:
After changes:
How to manually test the feature