SPIKE: CRM457-1920: PII enforcement #1203
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-laa
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
2 proof-of-concept specs to enforce keeping PII definitions up-to-date.
One assumes a PII yaml file has been created which explicitly marks certain DB columns as containing PII. To ensure this yaml file is maintained when new columns are added, this spec will fail unless every DB column has been marked as either PII or not.
The other spec assumes the repo contains a JSON Schema file which will be used to validate every payload that is generated or stored. It parses the file and checks to make sure that for every property (including nested object properties), a custom PII boolean annotation has been set.
These will ensure that adding new stuff to the database or payload will break the test suite unless those changes also include updating the PII definitions to match.