Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to get Selenium version and browser name #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rajeshtaneja
Copy link

@rajeshtaneja rajeshtaneja commented Feb 8, 2016

Closes #228

@aik099
Copy link
Member

aik099 commented Feb 8, 2016

The driver is called by Mink. These methods won't do any good for Mink.

The only use case I can imagine is that:

  • driver is created somewhere else
  • inside the test you need to detect which browser and Selenium server versions are used and do different things

If I'm correct, then by doing so you're forcing yourself to use Selenium Mink driver in the future as well.

@rajeshtaneja
Copy link
Author

I am planning to use this in beforeScenario for the first JS session to check if selenium version is greater then the supported version. $context->getSession()->getDriver()->getSeleniumVersion();

This is only used for putting the information using custom formatter.

@aik099
Copy link
Member

aik099 commented Feb 8, 2016

The getBrowserName function however is interesting one. Maybe it makes sense to add to DriverInterface, because other non-headless drivers might implement it as well. For example Sahi.

@aik099 aik099 changed the title #228 Add support to get Selenium version and browser name Add support to get Selenium version and browser name Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants