Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readme #19

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Improve readme #19

wants to merge 7 commits into from

Conversation

uuf6429
Copy link
Member

@uuf6429 uuf6429 commented Mar 5, 2024

Fixes #4.

@uuf6429 uuf6429 requested a review from aik099 March 5, 2024 20:58
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.24%. Comparing base (3b449c5) to head (3466441).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #19      +/-   ##
============================================
- Coverage     83.54%   82.24%   -1.31%     
  Complexity      191      191              
============================================
  Files             1        1              
  Lines           468      473       +5     
============================================
- Hits            391      389       -2     
- Misses           77       84       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Christophe Coevoet <[email protected]>
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@stof

This comment was marked as outdated.

@uuf6429

This comment was marked as outdated.

@stof

This comment was marked as outdated.

@uuf6429

This comment was marked as outdated.

@stof
Copy link
Member

stof commented Mar 6, 2024

We could copy it from the Testing section (maybe with a sentence mentioning that you could also run the browser-specific driver directly instead of Selenium depending on your use case)

@uuf6429 uuf6429 marked this pull request as draft March 7, 2024 18:53
@uuf6429 uuf6429 requested review from stof and aik099 March 10, 2024 16:12
LICENSE Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
.github/CONTRIBUTING.md Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
@uuf6429 uuf6429 requested review from aik099 and stof March 14, 2024 18:38
README.md Outdated Show resolved Hide resolved
@uuf6429 uuf6429 marked this pull request as ready for review June 29, 2024 19:37
README.md Outdated Show resolved Hide resolved
Co-authored-by: Christophe Coevoet <[email protected]>
@aik099
Copy link
Member

aik099 commented Oct 3, 2024

@uuf6429 , could you please remind me where the sample .behat.yml was supposed to live?

@uuf6429
Copy link
Member Author

uuf6429 commented Oct 3, 2024

@uuf6429 , could you please remind me where the sample .behat.yml was supposed to live?

@aik099 Didn't we say we're not providing a sample behat config? Otherwise I don't know what's this about..it's been quite a while now.

@aik099
Copy link
Member

aik099 commented Oct 3, 2024

@uuf6429 , could you please remind me where the sample .behat.yml was supposed to live?

@aik099 Didn't we say we're not providing a sample behat config? Otherwise I don't know what's this about..it's been quite a while now.

Would that sample configuration file be located in MinkExtension repo?

@uuf6429
Copy link
Member Author

uuf6429 commented Oct 4, 2024

Would that sample configuration file be located in MinkExtension repo?

@aik099 it feels more like it should be in the documentation somewhere. If we did put it in the repo, it would probably be lost (export-ignore'd), so devs wouldn't find it anyway.

@stof
Copy link
Member

stof commented Oct 4, 2024

MinkExtension has a doc folder, where it documents all drivers it supports with its factories. That's where things should go.
The Mink driver themselves should not care about the Behat extension that is using them.

@uuf6429
Copy link
Member Author

uuf6429 commented Oct 5, 2024

MinkExtension has a doc folder, where it documents all drivers it supports with its factories. That's where things should go. The Mink driver themselves should not care about the Behat extension that is using them.

It's the first time I see that - totally wasn't aware of it. The last change there is 7 years ago, by the way (that said it looks very useful, just maybe not very visible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update readme
3 participants