Skip to content

Commit

Permalink
save to artifact, not cache
Browse files Browse the repository at this point in the history
  • Loading branch information
miparnisari committed Oct 20, 2023
1 parent 3d7c6a9 commit a7ed361
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
comment-on-alert: true

- name: Save benchmark data
uses: actions/cache/save@704facf57e6136b1bc63b828d79edcd491f0ee84 # v3.3.2
- name: Save benchmark data without cache
- uses: actions/upload-artifact@v3
with:
path: ./cache/benchmark-data.json
key: ${{ runner.os }}-go-benchmark
name: benchmark-main
path: ./cache/benchmark-data.json
8 changes: 3 additions & 5 deletions .github/workflows/prs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,11 @@ jobs:
set -o pipefail
make bench | tee ${{ github.sha }}_bench_output.txt
# Download previous benchmark result from cache
# Download previous benchmark result
- name: Download previous benchmark data
uses: actions/cache/restore@704facf57e6136b1bc63b828d79edcd491f0ee84 # v3.3.2
- uses: actions/download-artifact@v3
with:
fail-on-cache-miss: true
path: ./cache/benchmark-data.json
key: ${{ runner.os }}-go-benchmark
name: benchmark-main

- name: Compare benchmark result
uses: benchmark-action/github-action-benchmark@70405016b032d44f409e4b1b451c40215cbe2393 # v1.18.0
Expand Down

0 comments on commit a7ed361

Please sign in to comment.