Skip to content

Commit

Permalink
roachtest: deflake perturbation/metamorphic/backfill
Browse files Browse the repository at this point in the history
The test runs a `cockroach workload run kv --db backfill ...` workload
to set the test up. It can fail if it encounters a transaction
retryable error.

This commit adds the `--tolerate-errors` flag to the workload command.

Fixes: cockroachdb#133374

Release note: None
  • Loading branch information
miraradeva committed Oct 24, 2024
1 parent c204063 commit be485b2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/admission_control_latency.go
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ func (b backfill) startTargetNode(ctx context.Context, t test.Test, v variations
// want the fill to impact the test throughput. We use a larger block size
// to create a lot of SSTables and ranges in a short amount of time.
runCmd := fmt.Sprintf(
"./cockroach workload run kv --db backfill --duration=%s --max-block-bytes=%d --min-block-bytes=%d --concurrency=100 {pgurl%s}",
"./cockroach workload run kv --db backfill --duration=%s --max-block-bytes=%d --tolerate-errors --min-block-bytes=%d --concurrency=100 {pgurl%s}",
v.perturbationDuration, 10_000, 10_000, v.stableNodes())
v.Run(ctx, option.WithNodes(v.workloadNodes()), runCmd)

Expand Down

0 comments on commit be485b2

Please sign in to comment.