Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary gated imports #18

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

eagr
Copy link
Contributor

@eagr eagr commented Dec 21, 2023

Some of the gated std imports are just re-exported from core/alloc, so we could just always use the core deps, no need to gate them.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e88414d) 100.00% compared to head (4d34f8a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          596       596           
  Branches       596       596           
=========================================
  Hits           596       596           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirromutth mirromutth added the enhancement New feature or request label Dec 22, 2023
Copy link
Owner

@mirromutth mirromutth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirromutth mirromutth merged commit 6eeec89 into mirromutth:main Dec 22, 2023
5 checks passed
@mirromutth mirromutth added this to the Release 0.2.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants