Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommonJS Support #113

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

CommonJS Support #113

wants to merge 3 commits into from

Commits on Jul 5, 2015

  1. Support CommonJS and fix UMD 

    I'm using this library with Browserify and found that it was unable to
detect d3 correctly.  This adds in the necessary `require` call to find
the d3 dependency.

I also changed the UMD signature to not expect that `define` and
`require` are globals in the sense of the runtime, but instead are
global within the encapsulating function scope (which may be the same as
the runtime's).  This will ensure d3.chart works as expected when
bundled.
    @tbranyen @jugglinmike
    tbranyen authored and jugglinmike committed Jul 5, 2015
    Configuration menu
    Copy the full SHA
    b6b6874 View commit details
    Browse the repository at this point in the history

  2. Declare dependency on d3.js for npm

    @jugglinmike
    jugglinmike committed Jul 5, 2015
    Configuration menu
    Copy the full SHA
    073167e View commit details
    Browse the repository at this point in the history

  3. Test CommonJS build 

    Use Browserify (courtesy of the "grunt-browserify" module) to build a
"test application" to ensure that this library properly functions in
CommonJS environments.
    @jugglinmike
    jugglinmike committed Jul 5, 2015
    Configuration menu
    Copy the full SHA
    74c71ee View commit details
    Browse the repository at this point in the history