[3.12] pythongh-104090: Fix unittest collectedDurations resources leak (

pythonGH-106795) (python#106888) pythongh-104090: Fix unittest collectedDurations resources leak (pythonGH-106795) (cherry picked from commit 70b961e) Co-authored-by: Yonatan Bitton <[email protected]>
miss-islington · Jul 19, 2023 · b1c50b8 · b1c50b8
1 parent 0c106a9
commit b1c50b8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/Lib/unittest/result.py b/Lib/unittest/result.py
@@ -166,7 +166,8 @@ def addDuration(self, test, elapsed):
         """
         # support for a TextTestRunner using an old TestResult class
         if hasattr(self, "collectedDurations"):
-            self.collectedDurations.append((test, elapsed))
+            # Pass test repr and not the test object itself to avoid resources leak
+            self.collectedDurations.append((str(test), elapsed))
 
     def wasSuccessful(self):
         """Tells whether or not this result was a success."""

diff --git a/Misc/NEWS.d/next/Tests/2023-07-16-02-57-08.gh-issue-104090.cKtK7g.rst b/Misc/NEWS.d/next/Tests/2023-07-16-02-57-08.gh-issue-104090.cKtK7g.rst
@@ -0,0 +1 @@
+Avoid creating a reference to the test object in :meth:`~unittest.TestResult.collectedDurations`.