Config file Auto-generation tool #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykaravas
force-pushed
the
config_file_updates
branch
2 times, most recently
from
f5c2f4e
to
4165df7
Compare
|
By the way, i am not sure what is causing this or if it is normal, but when i run the atomizer docker (on trunk or on this branch) it seems to fail:
2pc docker, all unit tests and integration tests seem to run just fine though. |
ykaravas
force-pushed
the
config_file_updates
branch
5 times, most recently
from
99b71b7
to
4837cc6
Compare
And, assert in all state_machine commit() and commit_config() hooks that incoming log_idx is one higher than last committed index Signed-off-by: Alexander Jung <[email protected]>
…I foresee much more expanded functionality in the future and a lot of potential. This will require some possible rework of some existing code, however, as well as integration tests to make use of this proposed functionality. Also reorganized config files into their own directory which seems neater. Also needed to fix docker stff. Might need to revert docker stuff. Not sure how that will affect others. Signed-off-by: Yiannis Karavas <[email protected]>
ykaravas
force-pushed
the
config_file_updates
branch
from
4837cc6
to
1204602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #136
Added configuration file autogeneration tool. I think there is still a lot that could be done here and there is potential for a lot more customization of tests/runs. The conversation is ongoing, however, this is a good spot to review and maybe even merge as it has basic functionality and is stable.
Moved configuration files around repo to their own directory, opencbdc-tx/config, for organizational purposes. Updated related scripts and docker yml files with new location of configs. This config dir houses an integration dir which holds integration test configs, unit dir, which holds unit test configs, a general dir, which holds the configs which were formerly in the project root dir and a tools dir which holds the config generator.
Created simple unit test for config generation as well which could be expanded a bit.