fix: Retry sentinel startup on failure #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalosGhost
force-pushed
the
fix/sentinel-startup-retry
branch
2 times, most recently
from
3411d13
to
0f529d4
Compare
In particular, retry N times (N = 4), increasing the retry delay on each failure (exponentially by factor of 2). This combination seems to give a reasonable level of stability. Co-authored-by: Michael L. Szulczewski <[email protected]> Signed-off-by: Sam Stuewe <[email protected]>
HalosGhost
force-pushed
the
fix/sentinel-startup-retry
branch
from
0f529d4
to
af6795f
Compare
|
CC: @karlovskiy, @mszulcz-mitre, @AlexRamRam, @metalicjames Would any of you mind pulling this change and testing locally. It seems to work quite reliably on my two test machines (one of which is woefully under-powered), but I'd love to get a second tACK before I merge it. |
|
@HalosGhost I've had chance to check your commit and it just works! |
|
@karlovskiy want to request your own review and add an approval? PR authors cannot approve their own PRs. :) |
|
@HalosGhost Ok. I'll be glad to ;) |
darbha-ram
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, infinitely retry starting the sentinel if its coordinator client fails to initialize.
Note: this probably isn't ideal; exponential back-off delay with a retry threshold (after which we should fatally error out) is probably better in the long-run. This, however, will suffice for now.
Edit: As infinite-retry causes the tests to fail, I've gone ahead and implemented a really basic threshold and increasing-delay. Currently, the threshold is
4retries, and the delay is exponential (increasing by a factor of two). I will be double-checking that the README walkthrough runs correctly (on a reasonably low-powered machine of mine) after the tests pass before I request review from someone else to try to make sure this will fix the issue (at least for most people).Fixes #186