Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Re-enable become/sudo tests, fix them on macOS runners #1168

Merged
merged 1 commit into from
Oct 28, 2024

Commits on Oct 27, 2024

  1. tests: Re-enable become/sudo tests, fix them on macOS runners

    The tasks in tests/imageprep/_user_accounts.yml that create users did not
    specify a primary group for those users - this left the decision to Ansible's
    user module, and/or the underlying OS. In Ansible 9+ (ansible-core 2.16+ the
    user module defaults to primary group "staff." Earlier don't supply a default,
    which releases probably results in a primary group nameed "None" (due to
    stringifying the Python singleton of the same name), or whatever the macOS
    Directory Services has for no data/NULL.
    
    The invalid GID 4294967295 (MAX_UINT32 == 2**32-1) in the sudo error probably
    enters the mix via something similar to sudo CVE-2019-14287.
    
    Fixes mitogen-hq#692
    
    See
    - ansible/ansible#79999
    - ansible/ansible@c69c83c
    - https://www.sudo.ws/security/advisories/minus_1_uid/
    
    > Bruce Wayne : [confused]  Am I meant to understand any of that?
    > Lucius Fox : Not at all, I just wanted you to know how hard it was.
    > -- Batman Begins
    moreati committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    8a34b92 View commit details
    Browse the repository at this point in the history