Target/source of app upload|download command should be arg, not flag #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-helmich
commented
Sep 4, 2024
| @@ -11,7 +11,7 @@ Manage apps, and app installations in your projects | |||
| * [`mw app dependency list`](#mw-app-dependency-list) | |||
| * [`mw app dependency update [INSTALLATION-ID]`](#mw-app-dependency-update-installation-id) | |||
| * [`mw app dependency versions SYSTEMSOFTWARE`](#mw-app-dependency-versions-systemsoftware) | |||
| * [`mw app download [INSTALLATION-ID]`](#mw-app-download-installation-id) | |||
| * [`mw app download [INSTALLATION-ID] TARGET`](#mw-app-download-installation-id-target) | |||
There was a problem hiding this comment.
Ah; now I remember why we didn't do this in the first place. This is not valid, because [INSTALLATION-ID] is optional any may not be followed by a required argument. So the only valid order would be TARGET [INSTALLATION-ID], which also seems unintuitive. I'll just close this and leave this as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR streamlines the flags+args of the
mw app upload|downloadcommand.Since these are required, it makes more sense to model them as positional arguments instead of flags.
Note that this change is very breaking, which is why we're introducing it before an eventual 1.0 release.
Fixes #394