Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/style: adjusted the primary buttons position #976

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix/style: adjusted the primary buttons position #976

wants to merge 1 commit into from

Conversation

BenniEngel
Copy link
Contributor

adjusted the primary buttons position if it is the only one in the action group

@BenniEngel BenniEngel linked an issue Nov 15, 2024 that may be closed by this pull request
Wrong position of primary Buttons in ActionGroup #971
Open
@BenniEngel BenniEngel self-assigned this Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 27.25% 3916 / 14368
🔵 Statements 27.25% 3916 / 14368
🔵 Functions 31.47% 214 / 680
🔵 Branches 55.07% 461 / 837
File CoverageNo changed files found.
Generated in workflow #1757 for commit 2c5567c by the Vitest Coverage Report Action

mfal
mfal requested changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@mfal mfal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work, if there are additional secondary buttons.

See Section "Zusätzlicher Secondary Button" in Style Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfal mfal mfal requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@BenniEngel BenniEngel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong position of primary Buttons in ActionGroup
2 participants
@BenniEngel @mfal