Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Configure Public Client #170

Merged

Conversation

xoanmi
Copy link
Contributor

@xoanmi xoanmi commented Aug 7, 2023

Basic implementation for the configure client.

Close #169

@xoanmi xoanmi changed the title GH-169: Implement Configure Public Client Implement Configure Public Client Aug 7, 2023
@xoanmi
Copy link
Contributor Author

xoanmi commented Aug 8, 2023

@elenz97 could you please check this PR?

@xoanmi xoanmi requested a review from elenz97 August 10, 2023 09:05
@xoanmi xoanmi requested a review from elenz97 August 10, 2023 09:57
@xoanmi xoanmi requested a review from elenz97 August 10, 2023 12:00
Copy link
Collaborator

@elenz97 elenz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for your contribution, @xoanmi

@elenz97 elenz97 merged commit 9162147 into mittwald:master Aug 10, 2023
5 checks passed
@xoanmi xoanmi deleted the featiure/GH-169_Implement_Configure_Client branch August 10, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurations client package
2 participants