Fix RESTClient not implementing v2 API Client interface #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elenz97 could you please check this PR? This don't allows us to perform proper mocking on the RESTClient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest changes some clients has been added on the V2 API without ensuring that RESTClient matches the Client interface:
https://github.com/mittwald/goharbor-client/blob/master/apiv2/client.go#L222 vs https://github.com/mittwald/goharbor-client/blob/master/apiv2/pkg/clients/configure/configure.go#L35
https://github.com/mittwald/goharbor-client/blob/master/apiv2/client.go#L268 vs https://github.com/mittwald/goharbor-client/blob/master/apiv2/pkg/clients/label/label.go#L38
Fixed this two references and added the following line to ensure that the RESTClient struct always implements the Client interface, preventing the following contributions to break the interface implementation:
var _ Client = (*RESTClient)(nil)