Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific setup instructions for Vue users #398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a-toms
Copy link

@a-toms a-toms commented Sep 11, 2021

Copy link

@srbala srbala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@domchristie domchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be a more general issue with ES6 imports rather than a Vue-specific problem. Perhaps we need to update package.json?

@srbala
Copy link

srbala commented Nov 27, 2021

If update to package.json solves the problem, that would be nice. This is PR is documentation update, anyone facing similar issue can resolve from it.

@pavelhoral
Copy link
Collaborator

pavelhoral commented Nov 28, 2021

This feels incorrect - the issue in the linked SO question seems to be with RequireJS and not at all connected with VueJS. So maybe you were not using the correct JS file (lib/turndown.browser.umd.js)?

For usage with RequireJS, UMD versions are located in lib/turndown.umd.js (for Node.js) and lib/turndown.browser.umd.js for browser usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants