-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add happy-dom and benchmark #457
base: master
Are you sure you want to change the base?
Conversation
So I guess the best option for now is to switch to a fork of domino, correct? |
If speed is the main concern, then yes the domino port passes all tests and is roughly the same speed as the original. I didn't check the source code of the port, was the issue described in #378 fixed? If everything is alright, I can cleanup the parser and make the PR ready. |
@martincizek what are your thoughts here? I'm trying to evaluate whether there will be a fix for this (I'm working in AWS Lambda) or if I need a different library. That's not meant to be hostile in any way, it's just "hey, have to pivot to keep moving forward" |
You could also consider patch-package to address the underlying problem in |
I checked both the original repo and https://github.com/fgnass/domino and the fork https://github.com/angular/domino for the It this this file in the original repo: That file doesn't exist in the fork and there is no other usage of this statement. So switching to this should work. |
Still work in progress.
EDIT:
jsdom
for comaprisonThis PR adds
happy-dom
as a potential replacement fordomino
due to the issues described in #378A new benchmark test was added in
test/benchmark.js
. Theprocess.env.PARSER
variable toggles betweenhappy-dom
anddomino
.Current results:
Other html parsers could be considered which are faster than
happy-dom
for this taskare listed here: