Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fastapi-mvc-template #106

Closed
wants to merge 1 commit into from
Closed

Conversation

rszamszur
Copy link
Contributor

Few reasons for your discretion why maybe to add yet another template:

  • The template utilizes WSGI + ASGI (Gunicorn with Uvicorn Workers) combination for the best performance possible.
  • It is structured in MVC architectural pattern to help developers who don't know FastAPI yet but are familiar with MVC to get up to speed quickly.
  • I've done my best to write this template in the most readable and Pythonic way (The Zen of Python) possible. Including docstrings and some clarifying comments here and there.
  • Base utilities for Redis and aiohttp clients.
  • Pipeline with build and tests (static checks, unit tests, coverage, and a placeholder for integration tests). Unit tests included :)
  • Helm chart for deploying in Kubernetes cluster.
  • Lastly, reproducible development environment with a script for bootstrapping local Minkube cluster with High Availability Redis cluster deployed using spotathome/redis-operator.

For future development, I'm planning to add features like:

  • Project generator
  • Multiple databases support
  • Implementations for OAuth and JWT

@mjhea0
Copy link
Owner

mjhea0 commented Dec 11, 2021

This project looks great. However, I'm only going to accept projects that are at least a year old and are consistently being updated. Please open this PR again in July 2022.

@mjhea0 mjhea0 closed this Dec 11, 2021
@Kludex
Copy link
Contributor

Kludex commented Dec 11, 2021

What about unmaintained projects that are on the list? (I think the subject is related)

@mjhea0
Copy link
Owner

mjhea0 commented Dec 11, 2021

I agree, @Kludex. Can you open an issue with the list of projects that are unmaintained that you think should be removed?

@Kludex
Copy link
Contributor

Kludex commented Dec 11, 2021

I don't have an opinion on that... I mean, I just asked an innocent question.

I'm asking about the strategy you want to follow:

  • Should we set a flag on the line to mark that it's unmaintained?
  • Should we open PRs automatically to evaluate the state of the project once the project is unmaintained after X months?
  • Define what is "unmaintained" for us. What does it mean to be unmaintained? A year without any update on the repository, or a year without any commit?
  • Not act at all. Remove only if a PR is received stating the reasons of the removal.

@mjhea0
Copy link
Owner

mjhea0 commented Dec 12, 2021

#109

@rszamszur rszamszur mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants