MJML6 Migrate from Lerna to NX, and introducing Typescript #2908
+1,855
−11,125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no ETA on this as I work on this on my free time.
I don't know if anyone will read this but given the time I have it's hard to find time to add new features into the codebase our test coverage purely sucks, releasing new version sucks, installing the project locally sucks.
So what's the plan ?
This would at least make MJML contribution WAY EASIER for everyone wanting to get involved in the project.
Why a v6 when v5 is not out yet ?
Ok so v5 was behind an "experimental" branch because of changing "core" elements for minifying/beautify the HTML, numbers might not be relevant, but there's 600k+ download per week of MJMl 4. If v5 was released, that would mean a lot of you would just jump in v5 finding new bug and giving my limited time I could work on MJML5 I wouldn't be able to patch it right away.
I don't feel safe releasing new version of MJML (so imagine for a major one when you replace core dep), so that's why v6 is needed to ensure we can provide safe & faster release.
New features when ?
Not planned for now, sorry for pushing 2 major versions without any groundbreaking feature.