-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Automatic Plugins #172
base: master
Are you sure you want to change the base?
Conversation
Hey @cdecoux, thanks a lot for this PR. I'll check it out in a few days! |
.goreleaser.yml
Outdated
# consumption by Packer.io. To include a separate docs.zip uncomment the following command. | ||
#- make ci-release-docs | ||
# Check plugin compatibility with required version of the Packer SDK | ||
# - make plugin-check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scaffolding repo (https://github.com/hashicorp/packer-plugin-scaffolding) originally had this make plugin-check
enabled and required a GNUmakefile from the same repo. I tried that myself and had a few errors, so I've bypassed it for now.
@cdecoux any idea where to put the binary during CI (no download from release page in that case) so that packer finds it without |
hm... the logs tell, that is actually detected
|
a80d61f
to
ea87ac7
Compare
@cdecoux Finished your PR... fixed the lint findings, added versioning so that Also did a release in my renamed fork of the repothat can be used for testing via the packer plugin init process:
I removed GPG signing for the time being (not required / afaik not checked by packer) and also disabled the non Linux binary builds (they are not useable). Important next step before the merge is renaming the repo to the pattern |
Awesome work! If the |
Hi guys, thanks for this PR!, I'm glad to see this change! |
@@ -21,3 +21,4 @@ | |||
.packer_plugins | |||
packer_cache | |||
packer-builder-arm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If changing name of the package, should this be kept?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If changing name of the package, should this be kept?
packer-builder-arm
will not be required anymore I guess.
Synced changes and resolved conflicts. Are we able to get this merged after renaming the repo to (and FYI, renaming the repo should automatically redirect https://github.com/mkaczanowski/packer-builder-arm to https://github.com/mkaczanowski/packer-plugin-arm) |
I thought I try your repo but I get the following error when building an image.
|
@jayofelony which OS are you using on the host? |
I'm using WSL Ubuntu under Windows 11. Trying to build an image for Raspios Bullseye 64bit. When I use the main repo it works like it should. |
Today I installed Ubuntu desktop on my laptop, and the same error is given there. But when I build packer-builder-arm from main repo and put the executable in builder folder all works normal. |
We apply the obvious aiming at rename and let this fork live its own life.
Packer added support for pulling in external plugins via a
required_plugins
block andpacker init
You can see the reference docs here: https://www.packer.io/plugins#installing-plugins
There's an existing issue out - #100 - to rename this repo to fit the naming convention. I attempted that in my fork, but turns out there's more stuff needed. I followed the docs for plugin development and referenced a scaffolding repo provided by Hashicorp to get a general idea of what needed to change. I made shortcuts to get a working example, so definitely could be improved upon to make properly updated, but hopefully this PR can be a good starting point for that.
I've got my fork built, released, and get a successful attempt:
Code:
Command:
packer init .
The added workflow is only triggered if a proper tag is pushed. The tag must be a valid Semantic Version preceded with a
v
.As of now, I have not tested actually using it. Nor have I tested this with the legacy usage. I'm just now learning about Packer ATM. Those should be done before merging this PR.