Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use invoke for predict calls and replace do.call for invoke where relevant #68

Merged
merged 6 commits into from
May 2, 2024

Conversation

m-muecke
Copy link
Member

@m-muecke m-muecke commented Apr 22, 2024

Changes:

  • Always use param_set$get_values() to access param set values
  • Use warningf() instead of custom warning condition
  • Set dbscan and co to density property instead of partioning
  • Always use invoke() in train and predict instead of do.call()
  • Use checkmate convention for naming of function names in custom assertions
  • Simplify the parameter checks where possible

@damirpolat damirpolat merged commit 9fbe815 into mlr-org:main May 2, 2024
4 checks passed
@damirpolat
Copy link
Member

Looks good to me. Thank you for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants