Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy rng state to callr session #104

Merged
merged 3 commits into from
Apr 9, 2024
Merged

fix: copy rng state to callr session #104

merged 3 commits into from
Apr 9, 2024

Conversation

be-marc
Copy link
Member

@be-marc be-marc commented Feb 2, 2024

No description provided.

sebffischer
sebffischer reviewed Feb 5, 2024
View reviewed changes
Copy link
Member

@sebffischer sebffischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to comment why this is needed, should not be super obvious I guess

@be-marc
Copy link
Member Author

be-marc commented Apr 9, 2024

I've added a few comments. Callr does not copy the RNG state into the external session and the changed state must also go back into the parent session.

@be-marc be-marc merged commit 45471b0 into main Apr 9, 2024
3 checks passed
@be-marc be-marc deleted the callr_rng branch April 9, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebffischer sebffischer sebffischer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@be-marc @sebffischer