-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching Prototype #382
Open
pfistfl
wants to merge
29
commits into
master
Choose a base branch
from
caching_playground
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Caching Prototype #382
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
904d164
Initial draft caching
pfistfl 2f9253c
Initial tests
pfistfl b1b5679
Caching md
pfistfl 7557694
more comments
pfistfl cf80785
Move caching to graph_reduce
pfistfl 27e84f3
Add current state
pfistfl f8147cd
Merge branch 'master' into caching_playground
pfistfl 86529b9
Document first caching draft
pfistfl 259b730
cached_pipeo_eval_fun
pfistfl 3ef805f
Errors in AB
pfistfl 7787088
Bug
pfistfl 416ae54
Disable tests
pfistfl bbad9d1
Add caching
pfistfl 1287e77
Test ABs
pfistfl 5b58cb7
Docs and finish up tests
pfistfl eef1240
Docs and finish up tests
pfistfl 639dc11
Fix tests
pfistfl 4b4b2be
fix up proxy
pfistfl fd147c4
polish docs
pfistfl 12cae42
move R.cache to suggests, cache tests to tempfile
pfistfl f096252
no on exit
pfistfl b5f18f1
move to imports
pfistfl 336748c
Disable caching tests
pfistfl a99f939
Merge remote-tracking branch 'origin' into caching_playground
pfistfl 2884fcd
re-enable tests
pfistfl d1c7d09
improve comments, cache tests tempfile
pfistfl 2547fb0
fix caching tempdir issues
pfistfl 2b75211
unlink testdir properly
pfistfl 2f8d118
Merge remote-tracking branch 'origin' into caching_playground
pfistfl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,7 @@ Imports: | |
mlr3misc (>= 0.1.4), | ||
paradox, | ||
R6, | ||
R.cache, | ||
withr | ||
Suggests: | ||
ggplot2, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,7 +75,8 @@ PipeOpNOP = R6Class("PipeOpNOP", | |
|
||
.predict = function(inputs) { | ||
inputs | ||
} | ||
}, | ||
.cache = FALSE | ||
) | ||
) | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be read-only and set during initialization?