New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIXME in PipeOpTaskPreproc #498

Open

damirpolat wants to merge 3 commits into mlr-org:master from damirpolat:op-preproc

Member

damirpolat commented Sep 7, 2020

Preprocessing operators used to remove features that were not selected from col_roles as described in FIXME comment.

I fixed the problem by saving removed col_roles and performing union with the processed columns.

Thanks,
Damir

damirpolat added 3 commits

September 7, 2020 13:58


          copying old col roles

31ccd4e


          Merge branch 'master' into op-preproc

0c1c460


          union removed and saved roles

cfb37b3

Member Author

damirpolat commented Sep 8, 2020

Not sure why checks are failing. Everything is fine when I run devtools:check() locally. Unless I'm missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet