New param use_groups for PipeOpSubsample and rework for task_filter_ex()
#834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mb706
requested changes
Oct 8, 2024
mb706
reviewed
Oct 10, 2024
|
todo: test with task where trailing rows were |
advieser
changed the title
use_groups for PipeOpSubsample use_groups for PipeOpSubsample and rework for task_filter_ex()
advieser
force-pushed
the
po_subsample_use_groups
branch
from
7dc3eeb
to
27d883c
Compare
…o po_subsample_use_groups # Conflicts: # NEWS.md
mb706
reviewed
Nov 5, 2024
| }, by = row_id] | ||
|
|
||
| # Use "new_groups" to update the group entries. | ||
| new_data[, (task$col_roles$group) := new_groups$group] |
There was a problem hiding this comment.
Test cases we want to check: Consider task with 3 rows, group 'a', 'b', 'c'; row roles "use" c(1, 1, 2, 2, 3)
- row_ids c(1, 1, 2, 2, 3) -> we get flattened task that has the same groups as before (has ids 1, 2, 3, 4, 5, groups 'a', 'b', 'c', 'a', 'b')
- row_ids c(1, 1, 1, 1, 2, 2, 3) -> add group a_1, i.e. task has c(1, 2, 3, 4, 5, 6, 7), groups 'a', 'b', 'c', 'a', 'b', 'a_1', 'a_1'
- row_ids c(1, 1, 1, 1, 3) -> same as above, but 'b' disappears: c(1, 3, 4, 5, 6), groups 'a', 'c', 'a', 'a_1', 'a_1'
- row_ids 3 -> groups a and b disappear: task has row-id 3, group 'c'
There was a problem hiding this comment.
- row_ids c(1, 1, 1, 1, 3, 1, 1) -> c(1, 3, 4, 5, 6, 7, 8), groups 'a', 'c', 'a', 'a_1', 'a_1', 'a_2', 'a_2'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #567
If
use_groups = TRUE(default), we subsample whole groups. This leads tofracnot being fully accurate.We currently don't support stratification (
stratify = TRUE) and subsampling grouped data at the same time, same as with Resamplings in mlr3.This changes the default behavior for tasks with a column with role "group".
Right now,
task$row_roles$useis not respected whenuse_groups = TRUE. Question is, how we would want to handle that? If a group contains any row that is not intask$row_roles$use, we ignore the group for subsampling?