Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disctime fixes #406

Merged
merged 30 commits into from
Jul 31, 2024
Merged

Disctime fixes #406

merged 30 commits into from
Jul 31, 2024

Conversation

bblodfon
Copy link
Collaborator

@bblodfon bblodfon commented Jul 26, 2024 •
edited
Loading

Need to fix tests:

  • ped_status during prediction is wrong?
  • row_ids must match the test ones
  • minimize transformed_data (no need to keep features in there as they match 1-1 with the output task)

bblodfon and others added 30 commits July 26, 2024 15:31
@bblodfon
Reapply "remove auxiliary code"
457a23d 
This reverts commit f74d5cf.
@bblodfon
Reapply "add dictionary sections in docs"
6753d2e 
This reverts commit 6c50246.
@bblodfon
Reapply "updocs"
dbbad12 
This reverts commit 06b0e8b.
@bblodfon
Reapply "test for same row ids in the test set"
0e323a6 
This reverts commit aa5a591.
@bblodfon
Reapply "test file renaming"
402a74d 
This reverts commit cb64a3a.
@bblodfon
Reapply "add test for discrete time task reduction"
4a07647 
This reverts commit 4be98ce.
@studener
update pipe to pass tests
8c42eb2
@studener
fix data.table global bindings
331963c
@studener
fix global bindings
3c554d8
@studener
delete file
b220585
@bblodfon
add "original_ids" col role
1b917b8
@bblodfon
unregister reflections
8e35065
@bblodfon
refactoring
bef1f90 
* better doc
* refactoring var names (new_data => lond_data, time2 => obs_times)
* add ids to "original_ids" role
@bblodfon
updocs
a01cdfc
@bblodfon
add package name
e4859a9
@bblodfon
update test, split train/test
e2b471c
@studener
edit transformed_data
3bc57fd
@studener
rename ped_status -> disc_status
a472af6
@studener
updocs
3fefd12
@studener
make sure that disc_status not in colnames
1d03507
@bblodfon
refactor test + add some more checks
8ea2c80
@bblodfon
rename file
1fea434
@bblodfon
add R-universe badge
c4cfba5
@bblodfon
fix note
e23e29f
@bblodfon
use testthat expectations for testing
3217512
@bblodfon
fix test
0d7ba22
@bblodfon
update docs
36044d9
@bblodfon
refactoring
3aeb622
@bblodfon
revert renaming of workflow file => capitalize name
7c0e129
@bblodfon
update version + news
bbd0c97
@bblodfon bblodfon merged commit 21a5dae into main Jul 31, 2024
4 checks passed
@bblodfon bblodfon deleted the disctime_fixes branch July 31, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bblodfon @studener