Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/tflog callback #290

Merged
merged 37 commits into from
Oct 18, 2024
Merged

Feat/tflog callback #290

merged 37 commits into from
Oct 18, 2024

Commits on Sep 10, 2024

  1. TODO: write tests

    @cxzhang4
    cxzhang4 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2380913 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. name -> TB. began refactoring based on last meeting with Sebastian

    @cxzhang4
    cxzhang4 committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    86f87c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. slight description change

    @cxzhang4
    cxzhang4 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    400ed74 View commit details
    Browse the repository at this point in the history

  2. removed extraneous comments

    @cxzhang4
    cxzhang4 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    9e6acd8 View commit details
    Browse the repository at this point in the history

  3. added n_last_loss frequency test

    @cxzhang4
    cxzhang4 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fc4f2fa View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. in progress

    @cxzhang4
    cxzhang4 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    81d1ded View commit details
    Browse the repository at this point in the history

  2. autotest working, accidentally used the wrong callback_generator

    @cxzhang4
    cxzhang4 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cb03eb3 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. simple and eval_freq tests pass

    @cxzhang4
    cxzhang4 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    78b95a5 View commit details
    Browse the repository at this point in the history

  2. changed logging methods to private

    @cxzhang4
    cxzhang4 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a365757 View commit details
    Browse the repository at this point in the history

  3. removed magrittr pipe from tests

    @cxzhang4
    cxzhang4 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    43a8ffb View commit details
    Browse the repository at this point in the history

  4. added details for callback class

    @cxzhang4
    cxzhang4 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6b9a845 View commit details
    Browse the repository at this point in the history

  5. formatting

    @cxzhang4
    cxzhang4 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d354b2c View commit details
    Browse the repository at this point in the history

  6. built docs

    @cxzhang4
    cxzhang4 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b5b27b1 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into feat/tflog-callback

    @cxzhang4
    cxzhang4 authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    565456b View commit details
    Browse the repository at this point in the history

  8. all tests pass, I think this is parity with the previous broken commi… 

    …t. still need to incorporate the step logging
    @cxzhang4
    cxzhang4 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7c9f431 View commit details
    Browse the repository at this point in the history

  9. implemented step logging

    @cxzhang4
    cxzhang4 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c6c9333 View commit details
    Browse the repository at this point in the history

  10. removed extraneous comments

    @cxzhang4
    cxzhang4 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    43e7396 View commit details
    Browse the repository at this point in the history

  11. added tensorboard instructions

    @cxzhang4
    cxzhang4 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ec5d8fc View commit details
    Browse the repository at this point in the history

  12. passes R CMD Check, minimally addresses every comment in the previous PR

    @cxzhang4
    cxzhang4 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f26a254 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. moved newest news to bottom

    @cxzhang4
    cxzhang4 committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    a86c946 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. logical -> flag, since the length of this arg must be 1 

    Co-authored-by: Sebastian Fischer <[email protected]>
    @cxzhang4 @sebffischer
    cxzhang4 and sebffischer authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    74757a7 View commit details
    Browse the repository at this point in the history

  2. "TensorBoard events" appears to be a more idiomatic phrase 

    Co-authored-by: Sebastian Fischer <[email protected]>
    @cxzhang4 @sebffischer
    cxzhang4 and sebffischer authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    72d23f4 View commit details
    Browse the repository at this point in the history

  3. map() -> walk(), since we don't use the return value of map() 

    Co-authored-by: Sebastian Fischer <[email protected]>
    @cxzhang4 @sebffischer
    cxzhang4 and sebffischer authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    beaca43 View commit details
    Browse the repository at this point in the history

  4. map() -> walk(), since we don't use the return value of map() 

    Co-authored-by: Sebastian Fischer <[email protected]>
    @cxzhang4 @sebffischer
    cxzhang4 and sebffischer authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1bf2939 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    setnames() is cleaner, allows us to create a list and set the names in a single line

Co-authored-by: Sebastian Fischer <[email protected]>
    @cxzhang4 @sebffischer
    cxzhang4 and sebffischer authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    03aad62 View commit details
    Browse the repository at this point in the history

  6. add a default value for the log_train_loss param 

    Co-authored-by: Sebastian Fischer <[email protected]>
    @cxzhang4 @sebffischer
    cxzhang4 and sebffischer authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e209092 View commit details
    Browse the repository at this point in the history

  7. add package dependency 

    Co-authored-by: Sebastian Fischer <[email protected]>
    @cxzhang4 @sebffischer
    cxzhang4 and sebffischer authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    694ea85 View commit details
    Browse the repository at this point in the history

  8. " Now that we have a default no need to specify log_train_loss" 

    Co-authored-by: Sebastian Fischer <[email protected]>
    @cxzhang4 @sebffischer
    cxzhang4 and sebffischer authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a8f741d View commit details
    Browse the repository at this point in the history

  9. better test description 

    Co-authored-by: Sebastian Fischer <[email protected]>
    @cxzhang4 @sebffischer
    cxzhang4 and sebffischer authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    795b3f1 View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Make test more efficient

Co-authored-by: Sebastian Fischer <[email protected]>
    @cxzhang4 @sebffischer
    cxzhang4 and sebffischer authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6b96aed View commit details
    Browse the repository at this point in the history

  11. unlist(map -> map_lgl

    @cxzhang4
    cxzhang4 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2113faf View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. removed library import in test file, added tfevents:: when we use a f… 

    …unction from tfevents
    @cxzhang4
    cxzhang4 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    afbb074 View commit details
    Browse the repository at this point in the history

  2. removed extra TODO, don't bind to variables when the value is only us… 

    …ed once
    @cxzhang4
    cxzhang4 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    074f73b View commit details
    Browse the repository at this point in the history

  3. remove more unnecessary vars, increase batch size to make tests run f… 

    …aster
    @cxzhang4
    cxzhang4 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5f7d56f View commit details
    Browse the repository at this point in the history

  4. access path field of callback, ifelse -> if

    @cxzhang4
    cxzhang4 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a1ddb7d View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. remove old todo

    @cxzhang4
    cxzhang4 authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3957614 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/tflog-callback

    @sebffischer
    sebffischer authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c95d241 View commit details
    Browse the repository at this point in the history